156 transmission make the change point sub section more intuitive #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ka-sarthak
deleted the
156-transmission-make-the-change-point-sub-section-more-intuitive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SettingOverWavelengthRangeclass which will be a parent for settings that vary over the wavelength range. It will define the limits of the wavelength, the value of the setting, and a name based on the wavelength limits. When such a setting is used in a sub-section, the label of each sub-section will be taken from its name: wavelength limits.WavelengthChangePointas it only contains one quantity and using it as a repeatable sub-section is not ideal. Instead, the change_point quantities can simply be quantities with ['*'] shape.Improve the description of the sections and quantitiesTo be done later