#243 Sprint22 Add stigmation correctors, removed unnecessary EM-Base Classes, opened NXcomponent for other techniques #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
… source inside tech partner file
lukaspie
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Mostly small questions, but I do have an issue as to how these new base classes are supposed to fit within the NXem ecosystem. Most of the new base classes are not used in NXem (or in the base classes that are specialized within NXem), so how are they supposed to be used in the appdef? As example, searches for NXmonochromator_em and NXcorrector_ax don't show them being cited anywhere else.
EDIT: I see that #251 adds most of them to NXem. Should anyway be checked that they are all cited?
#243 added connections to HMC EMglossary
… NXcomponent for technical components through removing electron microscopy specificity
… should be used for python>=3.12
… replaced all locations where NXaperture_em was used for NXaperture
mkuehbach
changed the title
3 tasks
…more meaty base class NXimage_set, the partner in crime for NXspectrum_set
…asses Fused NXimage_r_set, NXimage_c_set, NXimage_r_set_diff into a single …
Promote component_em to generally usable base class NXcomponent
mkuehbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.