Ellips reader and eln_data #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used in ellips reader
sanbrock
reviewed
May 30, 2023
domna
reviewed
May 31, 2023
domna
approved these changes
Jun 1, 2023
|
Please also remember to update the This should be done together with the release update in the example, i.e., when we set |
Co-authored-by: Florian Dobener <florian.dobener@physik.hu-berlin.de>
domna
reviewed
Jun 1, 2023
domna
reviewed
Jun 1, 2023
domna
reviewed
Jun 1, 2023
Pull Request Test Coverage Report for Build 5146557202
💛 - Coveralls |
RubelMozumder
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Reader for NXellipsometry(NXopt) * mock function for NXellipsometry(NXopt) * eln_data.yaml for NXellipsometry(NXopt) * New reader for NXellipsometry(NXopt) * Update mock.py * indentation * indentation * Update mock.py * Update mock.py * Updated metadata file to be consistent with new NXellipsometry * corrected some pycodestyle errors in the reader * corrected some pycodestyle errors * indentation * shortened lines * Added argument to FlattenSettings used in ellips reader * correcting some pylint errors * pycodestyle problems * Update reader.py * Update reader.py * Update reader.py * label function * removing err_labels * fixing header_labels args * Update reader.py * derived prms * data array functions * Update reader.py * removing unused argument header * Update reader.py * Update reader.py * removed blocks from config keys * update eln_data file * changing ang. spread unit * Corrections in the reader * Renamed black_list to ignore_keys * moved import math * Updating reader to be consistent with new eln * new eln file * Updated writer to handle attributs in ellips reader * updating definitions * Update pynxtools/dataconverter/readers/ellips/reader.py Co-authored-by: Florian Dobener <florian.dobener@physik.hu-berlin.de> * Updates eln_data to nomad generated one * Fixes key mapping --------- Co-authored-by: Florian Dobener <florian.dobener@physik.hu-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ellips reader and metadata file (eln_data.yaml)