Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

associating of organisations with users #1154

Closed
hoseinmirian opened this issue Jul 15, 2021 · 4 comments · Fixed by #1157
Closed

associating of organisations with users #1154

hoseinmirian opened this issue Jul 15, 2021 · 4 comments · Fixed by #1157
Assignees
Labels
Normal priority Priority for this task is normal

Comments

@hoseinmirian
Copy link
Contributor

hoseinmirian commented Jul 15, 2021

associating of organisations with users. allowing user to add new organisation and choose from the already existing organization.

@allysonlister

Good Afternoon Ally,

I need your thoughts about this subject:

How probable is that user wants to select multiple organisations and add or assign it to themselves?
image

In my opinion single select is giving a better user experience

second: for deleting an organisation I am showing a dialog confirming it before doing it, so for assigning an organisation to a user do you need it to be confirmed or happen instantly?

@hoseinmirian hoseinmirian added the Normal priority Priority for this task is normal label Jul 15, 2021
@hoseinmirian hoseinmirian self-assigned this Jul 15, 2021
@hoseinmirian hoseinmirian added this to To do in Phase 1: Client prototyping via automation Jul 15, 2021
@hoseinmirian hoseinmirian moved this from To do to Processing in Phase 1: Client prototyping Jul 15, 2021
@allysonlister
Copy link
Contributor

Thanks @hoseinmirian !

  1. There's two aspects to this answer. While I think that it is unlikely that a user would want to select more than one organisation from a single search (e.g. typing "NIH" and then choosing more than one from the resulting list), they are likely to need to be able to add multiple organisations, as sometimes people have more than one employer, e.g. contractors. I don't know how this would be implemented in the UI - that's your decision. But I'm happy to have no tickboxes in the search for "Available Organisations". It is enough for the user to be able to perform multiple searches, and then click on the row of the organisation they wish to add to their profile.
  2. "deleting an organisation": you mean removing the association between a user and an organisation, right? You're not actually deleting an organisation object? But yes, no need to confirm when a user adds an organisation - just add it. The confirmation for removing a link to an organisation is sufficient.

Thanks!

@hoseinmirian
Copy link
Contributor Author

I got all the answers I needed from your explanation. Thank you!

@allysonlister
Copy link
Contributor

Thanks! Yes people do need to define the organisation type.

hoseinmirian added a commit that referenced this issue Jul 21, 2021
@knirirr knirirr moved this from Processing to Done (pending approval) in Phase 1: Client prototyping Jul 22, 2021
@knirirr knirirr closed this as completed Jul 27, 2021
Phase 1: Client prototyping automation moved this from Done (pending approval) to Closed tasks Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Normal priority Priority for this task is normal
Projects
Development

Successfully merging a pull request may close this issue.

3 participants