Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the message if oauth login fails. #1255 #1256

Merged
merged 6 commits into from Oct 7, 2021
Merged

Conversation

knirirr
Copy link
Contributor

@knirirr knirirr commented Oct 7, 2021

If for some reason oauth fails a user would previously see this:

Screenshot 2021-10-07 at 09 56 03

Approve this PR, and they'll see this:

Screenshot 2021-10-07 at 09 55 38

@knirirr knirirr linked an issue Oct 7, 2021 that may be closed by this pull request
@knirirr
Copy link
Contributor Author

knirirr commented Oct 7, 2021

I've also changed the text on the login form a little as there were some small inconsistencies.

@knirirr knirirr changed the base branch from master to dev October 7, 2021 09:38
Copy link
Contributor

@ramGranell ramGranell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You failed!" is not a very polite sign

@knirirr
Copy link
Contributor Author

knirirr commented Oct 7, 2021

"You failed!" is not a very polite sign

Indeed. It looks like a placeholder used in development work that's been overlooked.

@knirirr knirirr merged commit aaf59d0 into dev Oct 7, 2021
@knirirr knirirr deleted the login_fail_fail branch October 7, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed login message
3 participants