Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved search 2140 #2299

Open
wants to merge 200 commits into
base: dev
Choose a base branch
from
Open

Saved search 2140 #2299

wants to merge 200 commits into from

Conversation

prakhyatox
Copy link
Contributor

@prakhyatox prakhyatox commented Apr 22, 2024

Ticket: #2140

@prakhyatox prakhyatox marked this pull request as draft April 22, 2024 10:41
prakhyatox and others added 23 commits April 22, 2024 13:37
@allysonlister
Copy link
Contributor

allysonlister commented Jul 31, 2024

Looking great!

  • major: unlinking a saved search from an 'other' user deletes the saved search from everywhere incl the owning user's account (rather than just unlinking from that 'other' user's account). In such cases, unlinking from an 'other' user should ONLY unlink it from that user. It is ONLY when you delete from the OWNING user's account that it deletes from everywhere. It may be that you then use the 'bin' icon only on the owning user's saved searches, and if a search is saved to an 'other' user perhaps the icon should be the 'unlink' icon?
  • major: when I unlink a saved search from an organisation, all other organisations that have that saved search are ALSO unlinked. It should be only removed from the specified organisation.
  • minor: Update the Saved Search explanatory text that is within the user profile table to "Clicking on the name of a saved search will take you to its search results. From the results page, if you are logged in you may further refine the search and/or save the search yourself. More information on ~~Conforming Resources and ~~Saved Searches can be found in our Gitbook documentation."
  • minor: Please could you put a newline in here? Or at least a space? --- Could not replicate this behvaiour in any screen dimension.

image

Reply:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants