Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers.Valid() fails on sets with InteractionFields as the header #30

Closed
zacsketches opened this issue Dec 20, 2018 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@zacsketches
Copy link
Contributor

The InteractionFields headers do not pass the Valid() test and therefore RecordSets generated by the solution cannot be opened for further processing.

Headers valid may be too brittle at this point to include in the package. As some point when the package gains more widespread use we might have enough knowledge to apply a Valid() check. However, the current version is a user protection that does not serve a useful purpose for the early adopters who understand their data.

At this point, since the use user community is so small I think the right thing to do is remove Valid(). The other option is to make Valid() a no-op and keep it in the repo for future implementation.

@zacsketches zacsketches added the bug Something isn't working label Dec 20, 2018
@zacsketches
Copy link
Contributor Author

Instead of the valid() function that is checked for a set of headers I think I'd like to move to a RecordSet.Validate(format FileFormat). The FileFormat argument is a series of constants that can be validated against. These constants provide a []string of required headers that must be in be in the file in order for it to validate against that format.

This still requires getting rid of the Valid() function.

zacsketches added a commit that referenced this issue Dec 27, 2018
Corrects issue #30

The Valid() function for a set of Headers was not robust against
different file sources for AIS data. This commit removes .Valid()
from the API.  A future enhancement may add
RecordSet.Validate(format FileFormat) method.  The priority for
this feature will be determined as more users provide feedback on
the tools that will make their work more robust.
@zacsketches
Copy link
Contributor Author

Closed by commit e27027b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant