Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve display of contributors #36

Closed
Createdd opened this issue Sep 22, 2017 · 13 comments
Closed

improve display of contributors #36

Createdd opened this issue Sep 22, 2017 · 13 comments

Comments

@Createdd
Copy link
Member

  • maybe add circular pictures to the names
  • make sure that all names are linked to their profile/homepage
  • sort alphabetical or according to contribute date
@himanshuc3
Copy link

I'd like to contribute mate!!

@robaxelsen
Copy link
Member

@himanshuc3 Great, thanks. We will get links and pictures from the contributors. Could you please create a PR where you use a dummy picture and links, and then we can add the real ones once ready?

@Createdd
Copy link
Member Author

Createdd commented Oct 6, 2017

@himanshuc3 Awesome! You are familiar with the workflow on Github? Just clone the repo, add your changes, push you branch and open a pull request.

In my opinion you can already use pictures from the Github repo and also add the links to their homepages/profiles if you want. :)

If you have any questions feel free to ask :)

@robaxelsen
Copy link
Member

@DDCreationStudios I went ahead and downloaded all pictures from the ones we have GiotHub profile links to. Would also like to add Monika Schrenk who's been having talks and helping out earlier. I also went ahead and contacted all the contributors with missing links, except for Manuel Matuzovic. Can you contact him?

@himanshuc3 I will add all the GitHub photos in a PR, and then you can use them once merged. Will tag you in the PR.

robaxelsen added a commit that referenced this issue Oct 6, 2017
To be used for PR related to #36.
robaxelsen added a commit that referenced this issue Oct 6, 2017
To be used for PR related to #36.
@robaxelsen
Copy link
Member

robaxelsen commented Oct 6, 2017

Link to add (will update when/if I get more links)
Adi Marvillo: https://github.com/darkhouse2
Achim Tecklenburg: https://github.com/achim-tecklenburg | Picture (consent given)
Manfred Specht: http://javascript.consulting/
Monika Schrenk: https://github.com/random-access

@robaxelsen
Copy link
Member

@himanshuc3 We decided to not add GitHub photos after all, due to legal/copyright issues. Please use a direct link to the GitHub profile pictures instead.

@phbrasiliano
Copy link
Contributor

Guys, I just found out that if you add .png at any given Github profile, you get a link to the users avatar. For example, my github profile link is https://github.com/phbrasiliano, if you add .png for that you can easily use the avatar https://github.com/phbrasiliano.png.
As they are all the same size, I guess using it them on the project would be easy.

@robaxelsen
Copy link
Member

Awesome, @phbrasiliano! Well spotted. That will be helpful for this issue.

Hi @himanshuc3, are you still working on this? If not, please let us know so we can re-assign the issue.

@rettetdemdativ
Copy link
Member

I'm also working on the issue right now so if that's ok, I could create a pull request in like half an hour max. I'm just not sure about whether contributors without a linked GitHub profile should have like a stock image instead of their GitHub one?

@rettetdemdativ
Copy link
Member

rettetdemdativ commented Oct 21, 2017

screenshot-2017-10-21 at 15 57 17
This is what I have right now. Any suggestions?

edit: I tried having the list items left-aligned so they're all in one line, but I don't think it looks good. Personally, I prefer the version in this screenshot.

@robaxelsen
Copy link
Member

@calmandniceperson looks great! Maybe we can just use GitHub's default profile avatar for the missing ones.

GitHub default profile avatar link

@rettetdemdativ
Copy link
Member

@robeerob Just added the default avatar to my pull request.

@robaxelsen
Copy link
Member

Closing this due to work of @calmandniceperson and help from @phbrasiliano. @himanshuc3 please create a new issue if you want to suggest any improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants