Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 desc-preproc_T2w not in resource pool #1620

Open
1 task
shnizzedy opened this issue Nov 17, 2021 · 1 comment 路 Fixed by #1622
Open
1 task

馃悰 desc-preproc_T2w not in resource pool #1620

shnizzedy opened this issue Nov 17, 2021 · 1 comment 路 Fixed by #1622
Labels
bug develop issue on `develop` branch engine Internal implementation changes that may not be visible to users.

Comments

@shnizzedy
Copy link
Member

Describe the bug

LookupError: When trying to connect node block 'coregistration' to workflow 'cpac_sub-NDARAA306NT2_ses-1' after node block 'coregistration_prep_fmriprep': 

[!] C-PAC says: The listed resource is not in the resource pool:
desc-preproc_T2w

Developer Note: This may be due to a mismatch between the node block's docstring 'input' field and a strat_pool.get_data() call within the block function.

To reproduce

Run default pipeline with bids_dir s3://fcp-indi/data/Projects/HBN/MRI/Site-RU

Expected behavior

cpac_pipeline adds a node block to generate this resource

Acceptance criteria

  • cpac_pipeline adds a node block to generate desc-preproc_T2w

Screenshots

No response

C-PAC version

v1.8.2-dev

Container platform

Docker

Docker and/or Singularity version(s)

Docker 20.10.7-0ubuntu5.1

Additional context

Discovered while working on #1610 (comment)

Seems to be the relevant section of the pipeline builder:

if not rpool.check_rpool('desc-preproc_T2w'):
# brain masking for ACPC alignment
if cfg.anatomical_preproc['acpc_alignment']['acpc_target'] == 'brain':
if rpool.check_rpool('space-T2w_desc-brain_mask'):
acpc_blocks_T2 = [
brain_extraction_temp_T2,
acpc_align_brain_with_mask_T2
# outputs space-T2w_desc-brain_mask for later - keep the mask (the user provided)
]
else:
acpc_blocks_T2 = [
brain_mask_acpc_T2,
# we don't want these masks to be used later, only used in brain_extraction_temp_T2
brain_extraction_temp_T2,
acpc_align_brain_T2
]
elif cfg.anatomical_preproc['acpc_alignment'][
'acpc_target'] == 'whole-head':
if rpool.check_rpool('space-T2w_desc-brain_mask'):
acpc_blocks_T2 = [
acpc_align_head_with_mask_T2
# outputs space-T2w_desc-brain_mask for later - keep the mask (the user provided)
]
else:
acpc_blocks_T2 = [
acpc_align_head_T2 # does not output nor generate a mask
]

@shnizzedy shnizzedy added bug engine Internal implementation changes that may not be visible to users. develop issue on `develop` branch labels Nov 17, 2021
@shnizzedy
Copy link
Member Author

I think this change should happen, but it doesn't seem to resolve this issue.

@shnizzedy shnizzedy linked a pull request Nov 18, 2021 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug develop issue on `develop` branch engine Internal implementation changes that may not be visible to users.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant