You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Only the first statement will be looped here (printf("%ld.%d: ", (long int)(b->p - b->start), b->bits_left);). Considering the following statements reference i, this is almost certainly undesirable.
This is reported as a warning by GCC (misleading-indentation):
/home/pi/git/RPiPlay/renderers/h264-bitstream/h264_sei.c: In function ‘read_debug_sei_payload’:
/home/pi/git/RPiPlay/renderers/h264-bitstream/h264_sei.c:686:13: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for ( i = 0; i < s->payloadSize; i++ )
^~~
/home/pi/git/RPiPlay/renderers/h264-bitstream/h264_sei.c:687:80: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘for’
printf("%ld.%d: ", (long int)(b->p - b->start), b->bits_left); s->data[i] = bs_read_u8(b); printf("s->data[i]: %d \n", s->data[i]);
The text was updated successfully, but these errors were encountered:
Zenexer
added a commit
to Zenexer/RPiPlay
that referenced
this issue
Dec 15, 2020
aizvorski/h264bitstream is an upstream library, & while I'm open to accepting compiler lint patches I'd prefer if they were upstream first and we just integrated a real release. For this particular package, I found a bunch of problems with in via fuzzing and I turn it off in my own build.
RPiPlay/renderers/h264-bitstream/h264_sei.c
Lines 686 to 687 in e485668
Only the first statement will be looped here (
printf("%ld.%d: ", (long int)(b->p - b->start), b->bits_left);
). Considering the following statements referencei
, this is almost certainly undesirable.This is reported as a warning by GCC (
misleading-indentation
):The text was updated successfully, but these errors were encountered: