Skip to content
This repository has been archived by the owner on Mar 24, 2019. It is now read-only.

New context format with JSon schema and two sample data files #2

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

lspiro-Tick42
Copy link
Contributor

This Pull request moves the Context data specification to match up with the current Intent definitions by allowing a data item (e.g. Instrument or Contact) to have multiple named formats (instead of just having a single data set with multiple field names).

This structure allows applications to register an Intent to only be relevant for a particular format of Instrument (for example only showing in-house position for an instrument if the Context holds the in-house instrument format )
NB An application Intent can be offered for multiple formats.

The Pull Request provides a JSon schema and two sample data files for this proposal.

@lspiro-Tick42
Copy link
Contributor Author

@finos-cla-bot[bot] check

@maoo
Copy link

maoo commented Oct 10, 2018

Merging this PR, since @lspiro-Tick42 is indeed covered by CLA with FINOS. The CLA Bot is flagging this PR due to (apparently) a configuration issue (see https://github.com/ColinEberhardt/cla-bot/issues/74); we will reproduce the same issue on https://github.com/finos-fdx/odp-test

@lspiro-Tick42
Copy link
Contributor Author

Mao asked me to add an approve comment since he had to initiate the PR. I have not created a branch, since I don't know what our WG branching policy is. This PR consists of 3 new files so could easily be unwound or moved to a branch if required.

@finos-admin finos-admin merged commit 83ffe34 into FDC3:master Oct 10, 2018
@rikoe
Copy link
Contributor

rikoe commented Oct 22, 2018

In my opinion this PR should be unmerged as it was never discussed during a working group call. I do not agree with some of the changes added here.

@ghost
Copy link

ghost commented Oct 24, 2018

The merge will be undone. Comments welcome on this PR.

@maoo
Copy link

maoo commented Oct 24, 2018

Thanks @tkolecke . I'm happy to rollback the Pull Request for you , please let me know if/when to proceed.

The last commit before the PR is be60e22 and there are no further commits afterwards, therefore a simple git reset --soft https://github.com/FDC3/ContextData/commit/be60e228d5b072d4c77559c2a134c881cfd713c2 would work.

@finos-admin
Copy link

Rolling back master branch now, on commit be60e22

@finos-admin
Copy link

Rollback completed, see https://github.com/FDC3/ContextData/commits/master

/CC @tkolecke @rikoe

ghost pushed a commit that referenced this pull request Nov 15, 2018
Bringing fork up to date
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants