Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel pool #131

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix channel pool #131

merged 1 commit into from
Jun 5, 2023

Conversation

ondrej-fabry
Copy link
Member

This change fixes the issue with channel pool causing the IDs be exhausted due to the pool deallocating the channels in the pool.
To resolve this there is a new pool for channel IDs which is used to cache unused channel IDs.
There are some minor changes in debug logs.

This change fixes the issue with channel pool causing the IDs be exhausted due to the pool deallocating the channels in the pool. To resolve this there is a new pool for channel IDs which is used to cache unused channel IDs.
There are some minor changes in debug logs.

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Copy link
Contributor

@sknat sknat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the fix ! Good catch 😮
Just a small comment on the slice backing the idpool.

core/channel.go Show resolved Hide resolved
@ondrej-fabry ondrej-fabry added the wip [status] In Progress label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug wip [status] In Progress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants