Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-button): 操作栏按钮的色值可能会取值不正确 #335 #336

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

yolofit
Copy link
Contributor

@yolofit yolofit commented Apr 23, 2021

fix #335

优化代码逻辑

  1. this.style是响应式对象且已绑定到模板里面,故32-35行代码貌似做了无用功?
  2. mounted时node已挂载,getComputedStyle(this.$el).color也就可以取到值,sleep 300s反而会造成取color值不对的几率

image

test:

image

@auto-add-label auto-add-label bot added the bug Something isn't working label Apr 23, 2021
@netlify
Copy link

netlify bot commented Apr 23, 2021

Deploy preview for el-data-table ready!

Built with commit ea1337f

https://deploy-preview-336--el-data-table.netlify.app

@yolofit yolofit closed this Apr 23, 2021
@yolofit yolofit reopened this Apr 24, 2021
@yolofit
Copy link
Contributor Author

yolofit commented Apr 24, 2021

2021-04-24.12.32.45.mov

@levy9527
Copy link
Contributor

只能说,那句 setTimeout 确实令人费解。。。毕竟有些历史了。。

@levy9527
Copy link
Contributor

@all-contributors add @yolofit bug

@allcontributors
Copy link
Contributor

@levy9527

I've put up a pull request to add @yolofit! 🎉

@levy9527 levy9527 merged commit 1fa5893 into FEMessage:dev Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

初始化data-table时,操作栏下的text button组件,color色值可能会取值不正确。
2 participants