Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in lib/types/chart-type.ts, ChartType.WordTree should be 'WordTree' not 'wordtree' #248

Open
kussmaul opened this issue Sep 1, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@kussmaul
Copy link
Contributor

kussmaul commented Sep 1, 2021

Bug Report

Description

lib/types/chart-type.ts defines enum ChartType. The last enum value is WordTree = 'wordtree' but should be WordTree = 'WordTree'.

To reproduce

  1. Visit this StackBlitz
  2. Open app.component.ts, which declares data used in sample charts.
  3. wType=ChartType.WordTree; produces an error: Invalid visualization type: wordtree
  4. wType = "WordTree" as ChartType; is a wordaround that shows the wordtree.
@kussmaul kussmaul added the bug Something isn't working label Sep 1, 2021
@kussmaul
Copy link
Contributor Author

kussmaul commented Sep 1, 2021

FYI - I found this while trying to debug another problem. WordTree worked fine for me (in Jan 2021), and then at some later point (not sure when) it stopped working. I don't think I changed anything (but it's certainly possible). Now I get a "TypeError : c is undefined" after ScriptLoaderService.loadChartPackages() calls https://www.gstatic.com/charts/loader.js.

I'm not sure if these problems are related, but the ChartType.WordTree problem might cause problems for getPackageForChart(), which could cause other problems.

@kussmaul
Copy link
Contributor Author

kussmaul commented Sep 3, 2021

I updated the StackBlitz to angular-google-charts 2.2.2, and now it also gives the error "c is undefined".
Should I open this as a separate issue?

@ramitvakil
Copy link

Hi,
Any update on the issue ? Anyone working on this? After I tried the workaround provided by @kussmaul it gives me the below error.
image

@FERNman Please if you could look into the issue?

@Vahlkron
Copy link

Hi, Any update on the issue ? Anyone working on this? After I tried the workaround provided by @kussmaul it gives me the below error. image

@FERNman Please if you could look into the issue?

I was able to get around the toLowerCase issue by reverting to 1.1.6, and using the "WordTree" as ChartType as previously mentioned by kussmaul. Hope this helps someone that is able to still use 1.1.6.

oobayly added a commit to tipstrade/angular-google-charts that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants