Production de openacc test #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandresm
requested changes
May 21, 2024
Comment on lines
-61
to
+63
|
|
||
| set(NV_GPU_ARCH "cc80" CACHE STRING "GPU arch for nvfortran compiler (cc35,cc50,cc60,cc70,cc80,...)") | ||
| option(DISABLE_OPENACC_ATOMICS "disable kernels using atomic statement for reproducible results" ON) | ||
| set(GPU_COMPUTE_CAPABILITY "cc80" CACHE STRING "GPU arch for nvfortran compiler (cc35,cc50,cc60,cc70,cc80,...)") | ||
| set(GPU_FLAGS "cuda12.2,${GPU_COMPUTE_CAPABILITY}" CACHE STRING "GPU arch for nvfortran compiler (cc35,cc50,cc60,cc70,cc80,...)") |
There was a problem hiding this comment.
@suvarchal, this was different from a previous version that was working on Levante. @basava70 replaced this line to have a variable that contains not only cc80 but cuda12.2,cc80 that is then passed to the -gpu flag during compilation. Does this change make sense to you?
…BLE_OPENMP to in src/CMakeLists.txt
basava70
commented
May 21, 2024
| set(CMAKE_EXE_LINKER_FLAGS "-acc -ta=tesla:${NV_GPU_ARCH}") | ||
| message("Taking ENABLE_OPENACC = ON") | ||
| target_compile_options(${PROJECT_NAME} PRIVATE -acc -O2 -gpu=${GPU_FLAGS} -Minfo=accel) | ||
| # set(CMAKE_EXE_LINKER_FLAGS "-acc -gpu=${GPU_FLAGS}") |
There was a problem hiding this comment.
@suvarchal @dsidoren @mandresm
I had to comment this particular line for the OpenACC code to work. I am not sure why. If anyone can let me know why, it will be great. But the code is running with this change.
|
Hi @basava70, thanks for the changes, I have no further comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has the working OpenACC code. I had to comment out
set(CMAKE_EXE_LINKER_FLAGS) line in src/CMakeLists.txt, among other things. But adding this line seems to break the code. Review it before merging.
Also this code is taking 25 seconds for 1 day. I think this is in accordance what @suvarchal got in LUMI.