Address review feedback

FEX-Emu · Jan 22, 2021 · 3030517 · 3030517
1 parent 00ca576
commit 3030517
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/External/FEXCore/Source/Interface/IR/Passes/RegisterAllocationPass.cpp b/External/FEXCore/Source/Interface/IR/Passes/RegisterAllocationPass.cpp
@@ -16,7 +16,13 @@ namespace {
 
   constexpr uint64_t INVALID_REGCLASS = (((uint64_t)INVALID_CLASS) << 32) | (INVALID_REG);
 
-  template<unsigned _Size = 6, typename T = uint32_t>
+  // BucketList is an optimized container, it includes an inline array of Size
+  // and can overflow to a linked list of further buckets
+  //
+  // To optimize for best performance, Size should be big enough to allocate one or two
+  // buckets for the typical case
+  // Picking a Size so sizeof(Bucket<...>) is a power of two is also a small win
+  template<unsigned _Size, typename T = uint32_t>
   struct BucketList {
     static constexpr const unsigned Size = _Size;