OpcodeDispatcher: Implements all the 3DNow! instructions #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directly matches the AArch64 instruction and will be used shortly
If multiblock isn't enabled then on Unimplemented op we shouldn't create a new block. Was causing IR validation to get angry
We already decoded the modrm `rm` bits, check while decoding modrm to ensure we don't try decoding it again. Was causing double decoding of SIB and displacement bytes, breaking things
Fully decoded the same way and adds the Geode specific instruction decodings as well.
This picks up all the instruction implementations, including 3DNow! Extended and the Geode specific instructions that were added. Most of these match preexisting SSE instructions except that they operate at 64-bit and in the MMX registers.
Now that we support these
Covers the full space, of which there aren't many. 3DNow! unit tests are disabled on the CI runner since the x86 CPU in CI doesn't support it.
This was referenced Mar 10, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up all the instruction implementations, including 3DNow!
Extended and the Geode specific instructions that were added.
Most of these match preexisting SSE instructions except that they
operate at 64-bit and in the MMX registers.