Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity_closure_dofs #240

Merged
merged 13 commits into from
Jun 23, 2021
Merged

Add entity_closure_dofs #240

merged 13 commits into from
Jun 23, 2021

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Jun 21, 2021

  • Added entity_closure_dofs function
  • Renamed entity_dofs to entity_dofs_count
  • Added new entity_dofs that returns a list of DOF numbers on each subentity

Fixes #235.

This PR requires corresponding changes in FFCx (FEniCS/ffcx#365) and DOLFINx (FEniCS/dolfinx#1582)

Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a query on a return type.

cpp/basix/cell.h Show resolved Hide resolved
@mscroggs mscroggs marked this pull request as draft June 22, 2021 07:39
@mscroggs mscroggs marked this pull request as ready for review June 22, 2021 09:13
@mscroggs mscroggs merged commit e6b3455 into main Jun 23, 2021
@mscroggs mscroggs deleted the mscroggs/entity_dofs branch June 23, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add entity closure dofs and entity dofs to Finite element.
2 participants