Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert variant names to lowercase to allow eg "GLL" to be used #392

Merged
merged 1 commit into from Mar 3, 2022
Merged

Convert variant names to lowercase to allow eg "GLL" to be used #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions python/basix/variants.py
View file
Open in desktop
Expand Up @@ -18,16 +18,16 @@ def string_to_lagrange_variant(variant: str) -> _LV:
basix.LagrangeVariant
The Lagrange variant
"""
if variant == "gll":
if variant.lower() == "gll":
return _LV.gll_warped
if variant == "chebyshev":
if variant.lower() == "chebyshev":
return _LV.chebyshev_isaac
if variant == "gl":
if variant.lower() == "gl":
return _LV.gl_isaac

if not hasattr(_LV, variant):
if not hasattr(_LV, variant.lower()):
raise ValueError(f"Unknown variant: {variant}")
return getattr(_LV, variant)
return getattr(_LV, variant.lower())


def lagrange_variant_to_string(variant: _LV) -> str:
Expand Down Expand Up @@ -61,9 +61,9 @@ def string_to_dpc_variant(variant: str) -> _DV:
basix.DPCVariant
The DPC variant
"""
if not hasattr(_DV, variant):
if not hasattr(_DV, variant.lower()):
raise ValueError(f"Unknown variant: {variant}")
return getattr(_DV, variant)
return getattr(_DV, variant.lower())


def dpc_variant_to_string(variant: _DV) -> str:
Expand Down