Fix __hash__ and __eq__ for basix.ufl elements #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscroggs
reviewed
Oct 27, 2023
garth-wells
reviewed
Oct 30, 2023
Changes: - merge changes from code review into my offline changes
|
Added tests for |
mscroggs
reviewed
Nov 1, 2023
mscroggs
reviewed
Nov 1, 2023
mscroggs
reviewed
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #717 by synchronizing the
repr(which is used to compute thehash) and__eq__functions for all element types inbasix.ufl.