-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matplotlib plotting #1327
Conversation
I would happily see Matplotlib removed and placed with vedo (https://vedo.embl.es/) and/or pyvista (https://docs.pyvista.org/). Matplotlib isn't a great experience for meshes, etc. |
Then we get back to having a VTK dependency in our code, which we removed from old dolfin. We have a PR for using pyvista: I could give vedo a go over the weekend. |
It's only a runtime dependency. |
I played around with vedo yesterday, and I like the interface for meshing more than I do for pyvista. I'll give the pyvista model another go tonight, moving some of the modules of #1161 to C++. However, I still think this PR should be merged, as it cleans up the docs and usage of plot (even if we will remove it in the future). |
Matplotlib is being deprecated, see: #1161 |
The current
dolfinx.plotting.plot
module is heavily outdated, for instance:DirichletBC
and the non-existentExpression
can be plotted with our backend, which is no longerTrue
. This PR updates the docs to match the usage of matplotlib keywords.mplot_dirichletbc
,create_cg1_function_space
andmplot_expression
are no longer used and should be removed, as done in this PR.