Move to C++20 #2111
Merged
Move to C++20 #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
requested review from
chrisrichardson,
jhale,
michalhabera and
IgorBaratta
michalhabera
approved these changes
Jul 14, 2022
IgorBaratta
reviewed
Jul 14, 2022
IgorBaratta
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Looks good to me.
My only concern are features that are not well supported across compilers, see
https://en.cppreference.com/w/cpp/compiler_support.
Which is not the case of this PR.
jhale
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires FEniCS/basix#563.
Removes
xtldependency in favour ofstd::span.GCC >= 10 required. Will allow code simplifications by using ranges and concepts from C++20.