Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for name of KaHIP library #2183

Merged
merged 2 commits into from
May 18, 2022
Merged

Update for name of KaHIP library #2183

merged 2 commits into from
May 18, 2022

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented May 18, 2022 •
edited

KaHIP changed its library name from interface to kahip.

Also skips KaHIP test when skipping of build tests is requested.

@garth-wells garth-wells marked this pull request as ready for review May 18, 2022 15:11
@garth-wells garth-wells merged commit be5fe15 into main May 18, 2022
@garth-wells garth-wells deleted the garth/kahip-lib-name branch May 18, 2022 15:39
@tiagovla
Copy link
Contributor

Shouldn't this be on by default?

dolfinx/cpp/CMakeLists.txt

Line 77 in 8e5bc85

option(DOLFINX_ENABLE_KAHIP "Compile with support for KaHIP." OFF)

@IgorBaratta
Copy link
Member

Shouldn't this be on by default?

dolfinx/cpp/CMakeLists.txt

Line 77 in 8e5bc85

option(DOLFINX_ENABLE_KAHIP "Compile with support for KaHIP." OFF)

KaHIP's build process is quite fragile.
So, if a user wants to use kahip, she/he should set DOLFINX_ENABLE_KAHIP=ON explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garth-wells @tiagovla @IgorBaratta