Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex mode in dolfinx/dolfinx images #2217

Merged
merged 9 commits into from
May 30, 2022
Merged

Conversation

jorgensd
Copy link
Sponsor Member

As far as I can tell, the issue is that the pip3 install command creates a build directory that caches some info when we build the dolfinx real and then complex mode.

I've added a test to the docker.yml CI that picks up this issue, and suggested a new fix (removing the build directories from dolfinx/python after installation.

Should hopefully resolve #2201

Remove build dirs in python folder after install
@francesco-ballarin
Copy link
Member

can we manually run the docker pipeline to test this?

@jhale
Copy link
Member

jhale commented May 30, 2022

The underlying reason for this might have been a change in pip related to switching from out-of-source to in-source builds, although I'm not certain.

Regarding the patch, I think it would be best to source our own configuration script dolfinx-complex-mode rather than manually setup the environment.

@jorgensd
Copy link
Sponsor Member Author

The underlying reason for this might have been a change in pip related to switching from out-of-source to in-source builds, although I'm not certain.

Regarding the patch, I think it would be best to source our own configuration script dolfinx-complex-mode rather than manually setup the environment.

I wasnt able to make a one-line command that did that with docker run. If you could show me how to do that I’d be grateful.

@jhale
Copy link
Member

jhale commented May 30, 2022

Misunderstood the thread, deleting.

@jhale
Copy link
Member

jhale commented May 30, 2022

I've triggered a build with this branch at b7e508b.

@jhale
Copy link
Member

jhale commented May 30, 2022

This patch hasn't fixed the issue. DOLFINx Python still seems to link to PETSc real mode libraries.

@jhale
Copy link
Member

jhale commented May 30, 2022

docker/Dockerfile Outdated Show resolved Hide resolved
@jhale jhale merged commit 042b9ba into main May 30, 2022
@jhale jhale deleted the dokken/fix-complex-mode branch May 30, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken complex mode in docker image
3 participants