-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing function parameter names of pybind11 generated functions #2222
Conversation
Is there a reason this isn't automatically available through pybind11? Maintaining these signatures could be cumbersome. |
I guess it is just not possible. From the pybind11 perspective, the function to wrap is just an object wrapping a function pointer. In C++ these pointers do not store the names of the function arguments. One thing that helps with maintainability though is that pybind11 will run some static asserts to check if the number of arguments matches the number of The same could be said for the C++ API documentation that is not translated automatically to the python API. |
I like the idea. Also for some reason your IDE or code linting has over formatted your code. |
Are you sure about the formatting? I made sure to run clang-format on each file. Just checked again and not seeing any diffs compared to the current version. |
https://github.com/FEniCS/dolfinx/runs/6676578989?check_suite_focus=true The formatting is OK according to the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely helpful for users, I just worry about maintenance.
@atouminet could you resolve the merge conflict? |
@garth-wells just rebased the PR and resolved the conflicts. |
Fixes #2220