Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to transfer_cell/facet_meshtags #2226

Merged
merged 8 commits into from
Jun 10, 2022

Conversation

jorgensd
Copy link
Sponsor Member

@jorgensd jorgensd commented Jun 1, 2022

  • Add asserts to make it possible to find missing connectivities in DEBUG mode.
  • Move mesh to avoid it being copied in MeshTags constructor.

The last point would cause issues when refining the mesh, then refining the tag and trying to write it to file.
You cannot create the required connectivities on the refined mesh, but currently have to access the copy through the meshtag.

@jorgensd jorgensd added the bug Something isn't working label Jun 1, 2022
cpp/dolfinx/refinement/utils.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/refinement/utils.cpp Outdated Show resolved Hide resolved
cpp/dolfinx/refinement/utils.cpp Outdated Show resolved Hide resolved
@garth-wells garth-wells merged commit 4e8a447 into main Jun 10, 2022
@garth-wells garth-wells deleted the dokken/refinement-asserts branch June 10, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants