Allow sparsity pattern to be built from integration entities #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Jun 16, 2022
Comment on lines
+38
to
+42
| for (std::int32_t c : cells) | ||
| { | ||
| pattern.insert(dofmaps[0].get().cell_dofs(c), | ||
| dofmaps[1].get().cell_dofs(c)); | ||
| } |
There was a problem hiding this comment.
Is it better with
std::for_each(cells.cbegin(), cells.cend(), auto [&dofmaps](auto c){
pattern.insert(dofmaps[0].get().cell_dofs(c), dofmaps[1].get().cell_dofs(c));
);? (Prone to github typing errors)
garth-wells
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to build a sparsity pattern from a list of integration entities i.e. cell indices for cell integrals, (cell, local_facet) pairs for exterior facet integrals etc. It also modifies
create_sparsity_patternso that it only adds entries for entities in the form's integration domains, rather than for all entities of a particular integration type.This PR is a step towards allowing the user to specify integration domains by passing a list of integration entities to
Form, which would allow, for example, one-sided integrals on the interior facets of the mesh. I plan to put in another PR soon to add this functionality.