Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to packaging and installation #2292

Merged
merged 14 commits into from
Jul 27, 2022

Conversation

jhale
Copy link
Member

@jhale jhale commented Jul 26, 2022

This PR removes the use of the latest tag. The latest tag has no clear meaning. Instead, images will either be tagged nightly, stable or specifically versioned e.g. v0.4.1. All public facing documents will prioritise the use
of the explicit stable tag. There will be further updates to be made in some of the other FEniCS components CI.

This also harmonises installation instructions in README.md.

@jhale
Copy link
Member Author

jhale commented Jul 26, 2022

I will probably have to do this commit as two stages to stop the CI breaking overnight.

@jhale jhale marked this pull request as ready for review July 27, 2022 10:11
@jhale jhale changed the title Remove latest Docker tag, prefer nightly or stable Updates to packaging and installation Jul 27, 2022
@jhale jhale requested a review from garth-wells July 27, 2022 11:29
@jhale jhale merged commit 7cb2300 into main Jul 27, 2022
@jhale jhale deleted the jhale/docker-deprecate-latest-terminology branch July 27, 2022 13:41
@francesco-ballarin
Copy link
Member

francesco-ballarin commented Jul 28, 2022

@jhale can you please login to docker hub and manually remove the latest docker tag, so that people realize that they must use the nightly tag? Related to this: what will happen if one uses docker pull dolfinx/dolfinx without any tag, and without latest being available? An error? latest will redirect to nightly?

(EDIT: sorry, I hadn't seen the message on slack concerning the removal of latest in 30 days)

@jhale
Copy link
Member Author

jhale commented Jul 28, 2022

No problem, I should have posted it here too!

The :latest tag will be removed in 30 days.

It is true we will no longer have a default tag :latest. I'd rather not point :latest at :nightly because then we will start having end users using :nightly with all of the issues that brings with support. I would rather stick with the new explicit design. If not having a :latest tag causes lots of issues we can revisit the issue at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants