Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release instructions #2303

Merged
merged 20 commits into from
Dec 19, 2022
Merged

Add release instructions #2303

merged 20 commits into from
Dec 19, 2022

Conversation

jhale
Copy link
Member

@jhale jhale commented Jul 29, 2022

Probably won't get all of this done in one go but it's a start.

@jhale
Copy link
Member Author

jhale commented Jul 29, 2022

The release branches are in a reasonable state for finalising a release.

RELEASE.md Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
@chrisrichardson
Copy link
Contributor

Another thing to mention, is that whilst the integration testing worked smoothly, the tags did not build the documentation the first time, because the CI was pointing to main and the compatibility requirement failed. I changed the CI to look at release branch for the dependencies, then it worked.
It may be better (perhaps) to update the versions in main before tagging?

@jhale
Copy link
Member Author

jhale commented Aug 31, 2022

Thanks for the explanation! I see the issue, I'll add something to the documentation.

In the content of DOLFINx, it would be great if the Actions simply read a JSON file with the git refs of the accompanying FEniCSx components, rather than having to change them manually in about 10 files.

@nate-sime
Copy link
Contributor

Should some details about adding a new version to the Spack packages be added in a future PR?

@garth-wells garth-wells changed the title Add release instructions. Add release instructions Sep 6, 2022
RELEASE.md Outdated
and mistakes before they reach tagged versions.

At each of the following links run the GitHub Action Workflow manually using
the `develop` branch in all fields. *Only proceed to tagging once all tests pass.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have develop branches?

@jhale jhale merged commit 790d79a into main Dec 19, 2022
@jhale jhale deleted the jhale/release-notes branch December 19, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants