Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xtensor #2356

Merged
merged 15 commits into from
Sep 9, 2022
Merged

Remove xtensor #2356

merged 15 commits into from
Sep 9, 2022

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Sep 8, 2022

This change removes xtensor. xtensor was used only in the C++ interface for mesh entity marking and user expressions. Other internal use was removed earlier.

Removing xtensor

  • reduces the number of dependencies
  • avoids ABI incompatibilities that can sneak in if xsimd is installed
  • avoids potential C++20 compatibility issues (xtensor does not support C++20)

Closes #2350.

@garth-wells garth-wells marked this pull request as ready for review September 9, 2022 08:33
@garth-wells garth-wells added the task A task to perform label Sep 9, 2022
@garth-wells garth-wells added this to the v0.6.0 milestone Sep 9, 2022
@francesco-ballarin
Copy link
Member

Is it correct to say that after this PR is merged none of the packages in the FEniCSx ecosystem will require xtl or xtensor?

If so, people like @drew-parsons and myself should make sure to remove such dependency in their packaging workflows.

@garth-wells
Copy link
Member Author

garth-wells commented Sep 9, 2022

Is it correct to say that after this PR is merged none of the packages in the FEniCSx ecosystem will require xtl or xtensor?

Yes, correct.

@garth-wells garth-wells merged commit 0ddbc45 into main Sep 9, 2022
@garth-wells garth-wells deleted the garth/remove-xtensor branch September 9, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A task to perform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove xtensor
3 participants