Fix bugs picked up by static analysis #2399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs picked up by SonarCloud.
Because the code with the two
except OSError
was incorrect (an exception block can only pickup a single exception type at a time) and used in three placesI decided to refactor the PETSc shared library loader into its own function. I removed the call to find the PETSc library using ctypes, this is likely to create a conflict with the version that petsc4py was compiled against. It still works if the library is in e.g.
/usr/local/lib
as shown by the successful RockyLinux CI run.