Rewrite Docker pipeline #2404
Merged
Rewrite Docker pipeline #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see a successful 'dummy' run of this workflow here: https://github.com/FEniCS/dolfinx/actions/runs/3250648594 |
jorgensd
reviewed
Oct 17, 2022
.github/workflows/docker.yml
Outdated
| -t dolfinx/dev-env:${{ steps.tag_name.outputs.TAG_PREFIX }} \ | ||
| dolfinx/dev-env:${{ steps.tag_name.outputs.TAG_PREFIX }}-amd64 \ | ||
| dolfinx/dev-env:${{ steps.tag_name.outputs.TAG_PREFIX }}-arm64 | ||
| # |
There was a problem hiding this comment.
Maybe add a comment saying that this is building the test-env
jorgensd
reviewed
Oct 17, 2022
.github/workflows/docker.yml
Outdated
| --tag ${GH_PREFIX}/${TAG} \ | ||
| ${DH_PREFIX}/${TAG}-amd64 \ | ||
| ${DH_PREFIX}/${TAG}-arm64 | ||
| # |
There was a problem hiding this comment.
Comment that this is building dev-env?
jorgensd
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the Docker image build pipeline.
docker/Dockerfile.dummyfor more rapid testing of CI steps.