Remove redefinition of VERSION_INFO
#2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrichardson
approved these changes
Oct 21, 2022
|
We should look and see if it's possible to move to a combined pyproject.toml/setup.py configuration for setuptools: https://setuptools.pypa.io/en/latest/userguide/ext_modules.html All of the metadata would be in pyproject.toml file, just the cmake stuff would remain in setup.py. |
|
We would need to move the flake8 options to a |
|
I don't think this is a good 'fix'. My understanding is that it versions the binaries. I suspect the problem lies elsewhere in the Spack config. |
|
Ok, let's revisit before a release. It was not documented, and seemed to have no purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing the python layer with Spack fails with
error: "VERSION_INFO" redefined. This PR removes the line whereVERSION_INFOis redefined.