Template mesh::Geometry over scalar type
#2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if there is a way to do this without templating |
|
@chrisrichardson suggestions? |
|
@jhale, @chrisrichardson, @IgorBaratta any further views? I'm coming around to this being the right approach. |
IgorBaratta
reviewed
Jan 31, 2023
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at dealing with compatibility between mesh geometry scalar types and form type by templating
mesh::Geometryover the scalar type. To get the performance benefits of reduced precision, we need the scalar types in a form to match, otherwise expensive casting is done behind the scenes.No guarantee that this is right approach, and if it is there is more work to handle the sharing of data. Putting it out there are this stage for comment. @IgorBaratta @jhale @chrisrichardson?