Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biharmonic demo (Python and C++) #2508

Merged
merged 15 commits into from
Mar 9, 2023
Merged

Conversation

juliusgh
Copy link
Contributor

@juliusgh juliusgh commented Jan 20, 2023

This PR adds following demos that solve the biharmonic equation using a discontinuous Galerkin method:

As far as I know, DOLFINx does so far not include a demo using discontinuous Galerkin methods. In my opinion this would be helpful for new users of DOLFINx and users who want to migrate old code from legacy DOLFIN.

@juliusgh juliusgh changed the title Add biharmonic demo Add biharmonic demo (Python and C++) Jan 22, 2023
@juliusgh
Copy link
Contributor Author

The generated CMakeLists.txt file of the demo was ignored by .gitignore, but the build pipelines do not automatically generate the file using python cmake/scripts/generate-cmakefiles, causing the regression tests to fail. I have forced Git to add the CMakeLists.txt file. Is this a good practice or what would be the way to go here?

@juliusgh juliusgh marked this pull request as ready for review January 22, 2023 14:09
@jhale jhale added this pull request to the merge queue Mar 8, 2023
@jhale jhale removed this pull request from the merge queue due to a manual request Mar 8, 2023
@jhale jhale enabled auto-merge March 8, 2023 15:25
@jhale jhale disabled auto-merge March 8, 2023 15:30
@jhale jhale enabled auto-merge March 8, 2023 15:30
auto-merge was automatically disabled March 8, 2023 23:31

Head branch was pushed to by a user without write access

@juliusgh
Copy link
Contributor Author

juliusgh commented Mar 8, 2023

Hi @jhale. Thank you for taking a look! In the meantime, there has been a small change in fem::apply_lifting. I have adjusted the demo and now the regression tests work again :)

@jhale jhale added this pull request to the merge queue Mar 9, 2023
Merged via the queue into FEniCS:main with commit c736689 Mar 9, 2023
@juliusgh juliusgh deleted the demo-biharmonic branch March 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants