Wrap mesh tags from Python #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdean
previously requested changes
Feb 7, 2023
|
Thanks @garth-wells, I'll test this with |
francesco-ballarin
approved these changes
Feb 7, 2023
jorgensd
reviewed
Feb 7, 2023
|
|
||
| new_meshtag = _cpp.refinement.transfer_cell_meshtag(meshtag, fine_mesh, parent_cell) | ||
|
|
||
| new_meshtag = _cpp.refinement.transfer_cell_meshtag(meshtag._cpp_object, fine_mesh, parent_cell) |
There was a problem hiding this comment.
I guess this indicates that we should wrap up refinement.transfer_cell_meshtag and refinement.transfer_facet_meshtag in the Python Layer.
This would probably be true for plaza_refine_data, as it returns a cpp.Mesh, which should be wrapped as a Python mesh.
There was a problem hiding this comment.
This will need further work to sort out.
Co-authored-by: Joe Dean <51745709+jpdean@users.noreply.github.com> Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
jorgensd
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap MeshTags from Python. Fixes #2519.
Also, a major simplification of building lists of entities to integrate over in
fem::Form. This will allow changes on the Python side that will be more forgiving of (mesh tag) marker type.