Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some mistakes in BoundingBox #2525

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix some mistakes in BoundingBox #2525

merged 2 commits into from
Feb 10, 2023

Conversation

chrisrichardson
Copy link
Contributor

There is a type error (should be int not double) for initial_entity and a few other things tidied up.

@jorgensd jorgensd self-requested a review February 10, 2023 10:06
@garth-wells garth-wells merged commit bb7ac95 into main Feb 10, 2023
@garth-wells garth-wells deleted the chris/bbox-fixes branch February 10, 2023 10:20
@garth-wells garth-wells added the bug Something isn't working label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garth-wells garth-wells garth-wells approved these changes

@jorgensd jorgensd jorgensd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisrichardson @garth-wells @jorgensd