Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend VectorFunctionSpace to custom elements #2576

Merged
merged 14 commits into from
Mar 16, 2023
Merged

Extend VectorFunctionSpace to custom elements #2576

merged 14 commits into from
Mar 16, 2023

Conversation

pierricmora
Copy link
Contributor

This PR would resolve #2557

mscroggs
mscroggs reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@mscroggs mscroggs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work for Basix UFL element, so I've added code suggestions changing the type to basix.ufl_wrapper._BasixElementBase. (The suggestions might need adjusting to make flake8 pass, getting the number of spaces right in this interface is hard.)

python/dolfinx/fem/function.py Outdated Show resolved Hide resolved
python/dolfinx/fem/function.py Outdated Show resolved Hide resolved
pierricmora and others added 2 commits March 8, 2023 21:34
@pierricmora @mscroggs
Apply suggestions from code review
66d46ac 
Co-authored-by: Matthew Scroggs <matthew.w.scroggs@gmail.com>
@pierricmora
Update function.py (adjust spaces)
a4eccb9
@pierricmora
Copy link
Contributor Author

Ok great, thank you. I adjusted the spaces.

@pierricmora
Copy link
Contributor Author

By the way, I took the line that you improved from the definition of the FunctionSpace class: line 470. Wouldn't it be relevant to also apply your change there (I won't do it)?

@mscroggs mscroggs mentioned this pull request Mar 9, 2023
Closed
mscroggs
mscroggs reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@mscroggs mscroggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested renaming to get mypy to pass

python/dolfinx/fem/function.py Outdated Show resolved Hide resolved
python/dolfinx/fem/function.py Outdated Show resolved Hide resolved
@mscroggs
Copy link
Member

By the way, I took the line that you improved from the definition of the FunctionSpace class: line 470. Wouldn't it be relevant to also apply your change there (I won't do it)?

I've opened an issue to remind myself to look into this: #2578

@pierricmora
Copy link
Contributor Author

Ok great, and thank you for the mypy fix. Is there anything else I should do? (Close the PR?) Or just wait for you/someone else to merge?

@mscroggs
Copy link
Member

Ok great, and thank you for the mypy fix. Is there anything else I should do? (Close the PR?) Or just wait for you/someone else to merge?

Just wait for someone to merge

@mscroggs mscroggs added this pull request to the merge queue Mar 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2023
@mscroggs mscroggs enabled auto-merge March 13, 2023 09:17
garth-wells
garth-wells requested changes Mar 13, 2023
View reviewed changes
python/dolfinx/fem/function.py Outdated Show resolved Hide resolved
python/dolfinx/fem/function.py Outdated Show resolved Hide resolved
@garth-wells garth-wells changed the title extend VectorFunctionSpace to custom elements Extend VectorFunctionSpace to custom elements Mar 13, 2023
@garth-wells garth-wells added the enhancement New feature or request label Mar 13, 2023
@mscroggs mscroggs disabled auto-merge March 13, 2023 09:25
@garth-wells garth-wells added this pull request to the merge queue Mar 16, 2023
Merged via the queue into FEniCS:main with commit 362f241 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscroggs mscroggs mscroggs approved these changes

@garth-wells garth-wells garth-wells approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make dolfinx.fem.VectorFunctionSpace compatible with ufl.FiniteElementBase?
3 participants
@pierricmora @mscroggs @garth-wells