Associate MeshTags with Topology (and not Mesh)
#2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
added
enhancement
garth-wells
changed the title
MeshTags with Topology (and not Mesh).MeshTags with Topology (and not Mesh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MeshTags data is defined on mesh entities (topology), and not a full mesh, i.e. geometry plays no role. The PR makes MeshTags depend on
Topologyand notMesh. This avoidsMeshTagshaving to be templated over the geometry scalar type.To make this work, a
Meshnow holds a shared pointer to its topology, allowing the topology to be shared with a MeshTags. This has the additional benefit of allowing meshes with different geometry scalar types to share a common topology.Fixes #2601.