Remove Python 'meta classes' #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
added
enhancement
jorgensd
added a commit
to ComputationalPhysiology/oasisx
that referenced
this pull request
Jul 4, 2023
jorgensd
added a commit
to ComputationalPhysiology/oasisx
that referenced
this pull request
Jul 4, 2023
* Removes usage of meta-classes, ref: FEniCS/dolfinx#2683 * formatting * Fix bc assembly * Fix python file
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes the Python 'meta classes', and instead wraps templated objects on the Python side. This is simpler, reduces the number of types that appear in Python, makes typing simpler and the docs work better.