Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mypy on petsc4py 3.20 types #2799

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Conversation

garth-wells
Copy link
Member

Somethig must have changed in PETSc.

Somethig must have changed in PETSc.
@francesco-ballarin
Copy link
Member

For reference, this is the upstream issue that tracks this https://gitlab.com/petsc/petsc/-/issues/1367

It is a nightmare to add # type: ignore at every single PETSc line. In my CI I simply remove the py.typed file from petsc4py see
https://github.com/RBniCS/RBniCSx/blob/main/.github/workflows/ci.yml#L38
since the above issue establishes that petsc4py is not really typed. I do realize that it may not be the ideal solution, since each developer would have to remember to do that in their own petsc4py installation.

@garth-wells garth-wells added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit f4e8ac4 Oct 1, 2023
20 checks passed
@garth-wells garth-wells deleted the garth/diable-mypy-petsc branch October 1, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants