Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add missing include <functional> #2810

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 6, 2023

needed for std::bind. Unclear under exactly what circumstances, but presumably it's sometimes implied by another dependency.

This is the compilation error with 0.7.0:

/home/conda/feedstock_root/build_artifacts/fenics-dolfinx-split_1696590289646/test_tmp/cpp/test/common/sort.cpp: In function 'void CATCH2_INTERNAL_TEMPLATE_TEST_0()':
/home/conda/feedstock_root/build_artifacts/fenics-dolfinx-split_1696590289646/test_tmp/cpp/test/common/sort.cpp:23:25: error: 'bind' is not a member of 'std'
   23 |   auto generator = std::bind(distribution, engine);
      |                         ^~~~
/home/conda/feedstock_root/build_artifacts/fenics-dolfinx-split_1696590289646/test_tmp/cpp/test/common/sort.cpp:12:1: note: 'std::bind' is defined in header '<functional>'; did you forget to '#include <functional>'?
   11 | #include <random>
  +++ |+#include <functional>
   12 | 

testing in conda-forge/fenics-dolfinx-feedstock#47 if you want to wait to confirm (same as #2808)

@garth-wells garth-wells added the bug Something isn't working label Oct 6, 2023
@garth-wells garth-wells added this pull request to the merge queue Oct 6, 2023
Merged via the queue into FEniCS:main with commit 19ea834 Oct 6, 2023
12 checks passed
@minrk minrk deleted the functional branch October 6, 2023 15:16
jhale pushed a commit that referenced this pull request Oct 10, 2023
needed for std::bind

Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants