Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary py.typed markers in python subpackages #2833

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

francesco-ballarin
Copy link
Member

py.typed markers in subpackages are not necessary, see

Package maintainers who wish to support type checking of their code MUST add a marker file named py.typed to their package supporting typing. This marker applies recursively: if a top-level package includes it, all its sub-packages MUST support type checking as well.

in https://peps.python.org/pep-0561/#packaging-type-information

Tested on https://github.com/FEniCS/dolfinx/actions/runs/6674824040 for dolfinx,
and with multiphenics/multiphenicsx@c677f42 and https://github.com/multiphenics/multiphenicsx/actions/runs/6674840436 on multiphenicsx to ensure that typing of dolfinx does not break with downstream projects.

@francesco-ballarin francesco-ballarin added the housekeeping Tidying and style improvements label Oct 28, 2023
@garth-wells garth-wells added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 72c9a89 Oct 30, 2023
20 checks passed
@garth-wells garth-wells deleted the francesco/rm-py-typed branch October 30, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Tidying and style improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants