Doc string improvement #2839
Merged
Doc string improvement #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
added
documentation
garth-wells
added a commit
that referenced
this pull request
Oct 30, 2023
* Improve comment (#2839) * Use `pyproject.toml` for install of Python part (#2707) * Try using pyproject * fixup pip command * Find python * debug * Try by adding path explicitly * Try no build isolation on mac. * Try this on macos. * Update CI * Typo * Fix. * Should be dependency of scikit-build-core. * Attempt fix for ubuntu. * Fix? * Add pyproject variant * Typo. * Explicit python intepreter. * Try forcing x86-64 arch. * Try this ordering. * Upgrade pip etc. * And on mac. * This works locally on my macOS system. pip install --no-build-isolation is required. * Works locally, not totally happy with the RPATH stuff. * Tidy. * Fix circleci * Tidy. * Update minimum pybind11. * Don't think these belong here. * Change email. * Tweaks to Dockerfiles and workflows. * Update macos workflow * Typo * Fix. * Get cmake to set rpath automatically. * Don't understand why but doesn't run on circleci, try this. * Typo * Tweak. * Update macos.yml * Try removing. * Exclude .cpp files as suggested. * Add --check-build-dependencies * Not necessary, think this is well known now. * Fix typo no install. * Update build-requirements.txt * Update pyproject.toml --------- Co-authored-by: Jack S. Hale <mail@jackhale.co.uk> Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk> * Update config * Small updates --------- Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Jack S. Hale <mail@jackhale.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
* First try to use nanobind with dolfinx [skip ci] * Fix pack coefficients [skip ci] * Disable petsc for now * Small fixes [skip ci] * Fix graph and geometry * Update to main * Get a few tests working * More fixes * remove duplicate line * hack dtype * updates * update for numpy_dtype * Install nanobind in CI * Install in right place * Fix one test * Fix a few issues * Fix complex dtype * Enable some PETSc * Some bits and pieces * More fixes * Enable more PETSc * Some fixes * Fix more failing tests * Get some cppimport working * More fixes * Get bindings to compile * Change nanobind install * CI updates * Updates * Update * Fix cast * Get building working * Updates * Update * Change linking * Get elasticity demo working * Tidy * Enable Constant value * Fix * Constants fix * IO fix * Limit tests * Disable doc tests * Add missing include * Fixes * Updates * Update demo * Comment out part of demo * Constrain array * Disable more code * Improvements * Disable MPI Python unit tests * IO update * flake8 fix * Disable some tests * flake8 fixes * Syntax fix * range fix * Get bbox working * Simplify * Fix test * Fix numba test * Fixes * Fix * Fix * Update demo * mypy fix * Demo fix * Disable doc ci * Parallel fix * reduce output * Relax doc generation * Enable more tests * Improvements * Fix * Improvement * Adj list fix * Try shared linking * Disable MPI/cppimport test * Simplify * Small fixes * Remove shared lib nanobind * Improve formatting * Include nanobind complex header * Run CI with complex * Type change * Work-around for possible bug in nanobind. nanobind seems to reject read-only complex Numpy arrays (real case is fine) * Bug fixes * Some work-arounds * Disable complex tests * Disable oneapi tests * flake8 fix * Enable complex test * Updates * Real tests only * Switch to writeable arrays * Enable some tests * Small update * Logic fix * Fixes * Get complex test passing * Enable more CI test images * oneAPI parallel tests * Use read-only PETSc Numpy arrays and use nanobind dev version (#2825) * Use read-only PETSc Numpy arrays and use nanobind dev version. * Demo fix * Install nanobind on CircleCI * Fix * Array improvements (nanobind) (#2827) * Simplify * Small fix * Simplify * Skip test * Simplifications * Small fix * Array shape improvements * Fixes * Revert to static nanobind lib * [nanobind] improve wrapping by ndarray (#2829) * Updates * Updates * Simplify * Small fix * flake8 fixes * Fixes * Small tidy up * Improvements (#2830) * [nanobind] array improvements (#2832) * Fix some arrays * Updates * Fix * Update * Simplifications * Improvements * Syntax improvements * Updates * Uncomment test body * Uncomment test * Disable test * [nanobind] improve casters (#2837) * Simplify moving data into arrays * More simplifying * Cast improvements * Work on casters * Fix casters * Remove test function * Tidy up * Type and formatting fix * Manage lifetime * Remove header * Remove print statements * Memory fix * Lifetime management fixes * Updates * Fix MPI * Fix call * Small updates * Work-around * Formatting fix * Work-around in casters * Add function to copy nanobind arrays * Remove a few more occurences of pybind11 (#2834) * [nanobind] merge pyproject change from main (#2840) * Improve comment (#2839) * Use `pyproject.toml` for install of Python part (#2707) * Try using pyproject * fixup pip command * Find python * debug * Try by adding path explicitly * Try no build isolation on mac. * Try this on macos. * Update CI * Typo * Fix. * Should be dependency of scikit-build-core. * Attempt fix for ubuntu. * Fix? * Add pyproject variant * Typo. * Explicit python intepreter. * Try forcing x86-64 arch. * Try this ordering. * Upgrade pip etc. * And on mac. * This works locally on my macOS system. pip install --no-build-isolation is required. * Works locally, not totally happy with the RPATH stuff. * Tidy. * Fix circleci * Tidy. * Update minimum pybind11. * Don't think these belong here. * Change email. * Tweaks to Dockerfiles and workflows. * Update macos workflow * Typo * Fix. * Get cmake to set rpath automatically. * Don't understand why but doesn't run on circleci, try this. * Typo * Tweak. * Update macos.yml * Try removing. * Exclude .cpp files as suggested. * Add --check-build-dependencies * Not necessary, think this is well known now. * Fix typo no install. * Update build-requirements.txt * Update pyproject.toml --------- Co-authored-by: Jack S. Hale <mail@jackhale.co.uk> Co-authored-by: Garth N. Wells <gnw20@cam.ac.uk> * Update config * Small updates --------- Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Jack S. Hale <mail@jackhale.co.uk> * Small edits * Enable test output * Move nanobind install to top for oneapi * oneapi update * Install scikit-build-core * Move steps in CI * Reduce test size * [nanobind] set to nanobind dev version in requirements (#2841) * Put git nanobind in requirements * Fix typo * Reinstate more oneapi tests * Tidy up * Revert mesh partition change * Remove test that isn't helpful * flake8 fix * Add skip for @entries in nanobind * Revert * Add back sphinx -W and try new version * Set nanobind version * Re-enable a float32 test * Fix CI * Simplify * Undo demo change * Re-enable partiton code. (#2859) * Add missing include * Disable nanobind leak messages in release mode * Run all oneAPI tests * Misc fixes and tidying * Remove cppimport examples * Replace std::vector with nb::ndarray * Array cast fix * Updates --------- Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk> Co-authored-by: Francesco Ballarin <francesco.ballarin@unicatt.it> Co-authored-by: Jack S. Hale <mail@jackhale.co.uk> Co-authored-by: Chris Richardson <cnr12@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.