Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for blocked elements with block size 1 #2955

Merged
merged 7 commits into from
Jan 5, 2024

Conversation

mscroggs
Copy link
Member

@mscroggs mscroggs commented Jan 3, 2024

Fixes #2944

@mscroggs mscroggs marked this pull request as draft January 3, 2024 16:28
@mscroggs mscroggs marked this pull request as ready for review January 3, 2024 17:20
@mscroggs mscroggs requested a review from jorgensd January 3, 2024 17:32
@jorgensd
Copy link
Sponsor Member

jorgensd commented Jan 4, 2024

Maybe add a test for the special case from the issue?

@garth-wells garth-wells added the bug Something isn't working label Jan 5, 2024
@garth-wells garth-wells added this pull request to the merge queue Jan 5, 2024
@garth-wells garth-wells removed this pull request from the merge queue due to a manual request Jan 5, 2024
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
@garth-wells garth-wells added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 03ce051 Jan 5, 2024
19 checks passed
@garth-wells garth-wells deleted the mscroggs/function-space-small-dim branch January 5, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FiniteElement::is_mixed is wrong for 1-dimensional vectors
3 participants