Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FFI support for calling C functions from Python/Numba #2968

Merged
merged 29 commits into from
Jan 8, 2024
Merged

Improve FFI support for calling C functions from Python/Numba #2968

merged 29 commits into from
Jan 8, 2024

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Jan 6, 2024 •
edited

  • Move Numba/ctypes/CFFI helpers into a utility module dolfinx.utils (is the name ok?).
  • Simplify custom assembly and kernel tests.
  • Parameterise custom assembly/kernel tests over scalar type.
  • Add case using Numba -specific support for calling C functions.

@garth-wells garth-wells added enhancement New feature or request housekeeping Tidying and style improvements labels Jan 6, 2024
@garth-wells garth-wells requested a review from jhale January 7, 2024 14:50
@garth-wells garth-wells marked this pull request as ready for review January 7, 2024 14:56
jhale
jhale approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@jhale jhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement, few minor comments.

python/demo/demo_static-condensation.py Outdated Show resolved Hide resolved
python/demo/demo_static-condensation.py Show resolved Hide resolved
python/demo/demo_static-condensation.py Show resolved Hide resolved
python/dolfinx/utils.py Show resolved Hide resolved
python/dolfinx/utils.py Outdated Show resolved Hide resolved
@jhale
Copy link
Member

jhale commented Jan 8, 2024

jhale/improve-ffi and https://github.com/FEniCS/ffcx/tree/jhale/low-level-kernel-smoothing

@jhale
Copy link
Member

jhale commented Jan 8, 2024

To be merged alongside FEniCS/ffcx#646

DOLFINx requires post-merge CI branch cleanup.

@jhale jhale mentioned this pull request Jan 8, 2024
Merged
@jhale jhale added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@jhale jhale enabled auto-merge January 8, 2024 20:46
@jhale jhale added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 57da7d1 Jan 8, 2024
19 checks passed
@jhale jhale deleted the garth/improve-ffi branch January 8, 2024 21:42
@jhale jhale mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhale jhale jhale approved these changes

@jorgensd jorgensd jorgensd left review comments

@chrisrichardson chrisrichardson Awaiting requested review from chrisrichardson

Assignees
No one assigned
Labels
enhancement New feature or request housekeeping Tidying and style improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garth-wells @jhale @chrisrichardson @jorgensd