Re-name overloaded create_form function
#3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
added
enhancement
garth-wells
changed the title
create_form functioncreate_form function
chrisrichardson
approved these changes
Jan 30, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have three
create_formoverloaded functions. Two take form coefficients and constants that are associated with a name (string). This allows coefficients to be set by the name used in a UFL file. Onecreate_formtakes coefficients and constants that are in the required order.The problem with this overloading is when a form has no coefficients or constants and one pass empty initializer lists (
{}), which is the simplest syntax, the compiler cannot resolve the overload.This change re-names the
create_formfunction that requires data in the correct order tocreate_form_factory. There are no changes top C++ demos or tests, and no changes to Python.