Add interface to mesh::Geometry for multiple cmaps and dofmaps
#3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrichardson
commented
Feb 7, 2024
chrisrichardson
commented
Feb 7, 2024
chrisrichardson
commented
Feb 7, 2024
chrisrichardson
commented
Feb 7, 2024
Co-authored-by: Joe Dean <jpd62@cam.ac.uk>
Makes clearer where updates will be needed.
garth-wells
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming towards mixed-topology meshes, this adds extra interfaces to
mesh::Geometryfor multiple dofmaps and cmaps,although only using one of each at the moment.
With a future update of
dofmapbuilderthis will allow the Geometry to have separate dofmaps for different cell types.