Simplify Form constructor by adding a struct for integral data
#3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrichardson
approved these changes
Feb 8, 2024
garth-wells
requested changes
Feb 8, 2024
|
I'm not 100% sure on the syntax suggestions with |
garth-wells
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integrals argument in the
Formconstructor isn't very easy to read. I've added astructto simplify things (this will also help make the code more readable when mixed-domain support is added), and I've removed astd::map. The struct is templated over container type to avoid some copies, but maybe this isn't the best solution.