-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor la.Vector.norm
#3108
Refactor la.Vector.norm
#3108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, even if it means that we change the API:P
Only request is to add support for l1 and l-inf norms for integers, as they are supported. "l2" is clearly not supported.
I guess if @garth-wells or @IgorBaratta or @chrisrichardson has any opinions on this please chip in:)
Regarding supporting norms of vectors of integral types, I'm having a little trouble coming up with a neat way to deduce the underlying type of a vector of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments - will post tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a micro change suggestion.
I think this one's ready to go now if we can put it in the merge queue, @garth-wells ? |
Closes #3103.
Refactor
la.Vector.norm
into a function to reflect the C++ layer.Add implementation of integer types for
la.Vector
.Redesign the
la.Vector
tests to parametrize overdtype
as well asxfail
on unsupported (or not yet implemented) norm types.